Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payment): add more payment channels than just email and phone (think: chat) #42148

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat(payment): add more payment channels than just email and phone (think: chat) #42148

merged 1 commit into from
Jul 18, 2024

Conversation

blaggacao
Copy link
Collaborator

Part of #40845

cc @ruthra-kumar

This implements an appropriate payment channel (not email or phone), which is implemented by one of the target gateways (e.g. whatsapp link or app-/push-notification-based).

None of the current channels is suitable for that business logic.

@blaggacao
Copy link
Collaborator Author

Fears are nothing more than a state of mind. - Napoleon Hill

Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach

Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch your character, it becomes your destiny. -

Kindly help move this PR forward. Many thanks from Yours Sincerely!

@ruthra-kumar ruthra-kumar merged commit 79a46ad into frappe:develop Jul 18, 2024
12 of 13 checks passed
@blaggacao blaggacao deleted the payments/pr-4 branch July 18, 2024 11:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruthra-kumar ruthra-kumar ruthra-kumar approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaggacao @ruthra-kumar